dsccommunity / ConfigMgrCBDsc

This module contains DSC resources for the management and configuration of Microsoft System Center Configuration Manager Current Branch (ConfigMgrCB).
MIT License
27 stars 8 forks source link

Update module versions #100

Closed nyanhp closed 2 years ago

nyanhp commented 2 years ago

Pull Request (PR) description

Update module versions of NetworkingDsc, SqlServerDsc, ComputerManagementDsc as NetworkingDsc and SqlServerDsc were seriously outdated.

This Pull Request (PR) fixes the following issues

None

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #100 (1630f72) into master (082b725) will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #100   +/-   ##
=====================================
  Coverage      98%    98%           
=====================================
  Files          60     60           
  Lines        8583   8583           
=====================================
  Hits         8448   8448           
  Misses        135    135           
jeffotterpohl commented 2 years ago

In the xSccmSqlSetup.schema.psm1, SqlServerNetwork EnableTcpIp configuration section, since SqlServerNetwork was removed in the version specified in the PR for SQLServerDSC, should be removed and replaced so the composite will still function correctly. The current needs replaced with:

    SqlProtocolTcpIp SetTcpIpPort
    {
        InstanceName    = $SqlInstanceName
        IpAddressGroup = 'IPAll'
        TcpPort               = $SqlPort
        DependsOn        = '[SqlSetup]InstallSql'
    }

Thanks!

nyanhp commented 2 years ago

In the xSccmSqlSetup.schema.psm1, SqlServerNetwork EnableTcpIp configuration section, since SqlServerNetwork was removed in the version specified in the PR for SQLServerDSC, should be removed and replaced so the composite will still function correctly. The current needs replaced with:

    SqlProtocolTcpIp SetTcpIpPort
    {
        InstanceName    = $SqlInstanceName
        IpAddressGroup = 'IPAll'
        TcpPort               = $SqlPort
        DependsOn        = '[SqlSetup]InstallSql'
    }

Thanks!

Done!