Closed nyanhp closed 2 years ago
Merging #100 (1630f72) into master (082b725) will not change coverage. The diff coverage is
0%
.
@@ Coverage Diff @@
## master #100 +/- ##
=====================================
Coverage 98% 98%
=====================================
Files 60 60
Lines 8583 8583
=====================================
Hits 8448 8448
Misses 135 135
In the xSccmSqlSetup.schema.psm1, SqlServerNetwork EnableTcpIp configuration section, since SqlServerNetwork was removed in the version specified in the PR for SQLServerDSC, should be removed and replaced so the composite will still function correctly. The current needs replaced with:
SqlProtocolTcpIp SetTcpIpPort
{
InstanceName = $SqlInstanceName
IpAddressGroup = 'IPAll'
TcpPort = $SqlPort
DependsOn = '[SqlSetup]InstallSql'
}
Thanks!
In the xSccmSqlSetup.schema.psm1, SqlServerNetwork EnableTcpIp configuration section, since SqlServerNetwork was removed in the version specified in the PR for SQLServerDSC, should be removed and replaced so the composite will still function correctly. The current needs replaced with:
SqlProtocolTcpIp SetTcpIpPort { InstanceName = $SqlInstanceName IpAddressGroup = 'IPAll' TcpPort = $SqlPort DependsOn = '[SqlSetup]InstallSql' }
Thanks!
Done!
Pull Request (PR) description
Update module versions of NetworkingDsc, SqlServerDsc, ComputerManagementDsc as NetworkingDsc and SqlServerDsc were seriously outdated.
This Pull Request (PR) fixes the following issues
None
Task list
This change is