dsccommunity / ConfigMgrCBDsc

This module contains DSC resources for the management and configuration of Microsoft System Center Configuration Manager Current Branch (ConfigMgrCB).
MIT License
27 stars 8 forks source link

CMDistributionGroup add collection members #110

Closed nyanhp closed 1 year ago

nyanhp commented 2 years ago

Pull Request (PR) description

Resource CMDistributionGroup can now also match, include and exclude Collections.

Tested in lab environment using the updated example for this resource.

This Pull Request (PR) fixes the following issues

None

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #110 (4a858b2) into master (7432eca) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #110   +/-   ##
=====================================
  Coverage      98%    98%           
=====================================
  Files          62     62           
  Lines        9027   9077   +50     
=====================================
+ Hits         8928   8978   +50     
  Misses         99     99           
nyanhp commented 1 year ago

Sorry folks, I don't know how to properly pass the tests here without modifying the stubs. Please let me know what needs to be done. The existing code seems to be too complex for me to be able to "make it work" in a reasonable amount of time, unfortunately. If modifying the stubs is not desired, please close this PR and I will use my fork at my customer.

nyanhp commented 1 year ago

In addition to my inability to pass the unit tests, the HQRM tests are failing due to an updated version of ChangelogManagement: - BREAKING CHANGE: Get-ChangelogData''s Output.Unreleased is now null if there are no unreleased changes to match the behavior of Output.Released