dsccommunity / ConfigMgrCBDsc

This module contains DSC resources for the management and configuration of Microsoft System Center Configuration Manager Current Branch (ConfigMgrCB).

MIT License

27 stars 8 forks source link

Change pipeline build stage to use windows-latest #112

Closed NEllis280 closed 1 year ago

NEllis280 commented 1 year ago

Restricting version of Sampler to pass build

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

codecov[bot] commented 1 year ago

Codecov Report

Merging #112 (09673d7) into master (4a858b2) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #112   +/-   ##
=====================================
  Coverage      98%    98%           
=====================================
  Files          62     62           
  Lines        9077   9077           
=====================================
  Hits         8978   8978           
  Misses         99     99

johlju commented 1 year ago

Are you seeing build fails with latest Sampler? Curious what fails...

NEllis280 commented 1 year ago

Are you seeing build fails with latest Sampler? Curious what fails...

The latest build is failing because i think it's not seeing the schema.mof for one of the x resources

https://dev.azure.com/dsccommunity/ConfigMgrCBDsc/_build/results?buildId=7330&view=logs&jobId=0293d6db-8469-5a47-abbc-6f6aba61562f&j=0293d6db-8469-5a47-abbc-6f6aba61562f&t=4fff1e01-0f29-59ad-a7ee-7e9cb6dea69b

johlju commented 1 year ago

I created an issue to track it: https://github.com/gaelcolas/Sampler/issues/410

Have you tested that the build fails the same way on Windows too?

johlju commented 1 year ago

If a better workaround is to move the build stage from ubuntu 20.04 to build worker windows-latest, but won't do any good if build fails on Windows. There is an issue with MOF resources with ubuntu-latest (ubuntu 22.04) so cold be a good idea to move the build stage to windows-latest regardless.