search

dsccommunity / ConfigMgrCBDsc

This module contains DSC resources for the management and configuration of Microsoft System Center Configuration Manager Current Branch (ConfigMgrCB).
MIT License
27 stars 8 forks source link

CMCollections: Embedded instance DSC_CMCollectionRefreshSchedule seems unnecessary #25

Closed johlju closed 3 years ago

johlju commented 4 years ago

In the schema for the resource DSC_CMCollections there is an embedded instance class DSC_CMCollectionRefreshSchedule that looks unnecessary. It looks like the properties in this class could be moved into the resource schema instead.

https://github.com/dsccommunity/ConfigMgrCBDsc/blob/fac77a0e87510c70ea90c35d8a77dc41afa47bd4/source/DSCResources/DSC_CMCollections/DSC_CMCollections.schema.mof#L17-L22

If the property RefreshSchedule would take an array of DSC_CMCollectionRefreshSchedule I would understand the need for it, but now it looks like we could add two properties to the schema instead; RefreshScheduleRecurInterval and RefreshScheduleRecurCount.

NEllis280 commented 3 years ago

When we issue a PR to fix this, we will need to ensure we are properly handling inputs that exceed the maximum allowed interval.

NEllis280 commented 3 years ago

PR #78 Resolves this