dsccommunity / ConfigMgrCBDsc

This module contains DSC resources for the management and configuration of Microsoft System Center Configuration Manager Current Branch (ConfigMgrCB).
MIT License
27 stars 8 forks source link

CMSystemDiscovery - Adding Parameter Validation #80

Closed NEllis280 closed 3 years ago

NEllis280 commented 3 years ago

Pull Request (PR) description

This PR adds warnings to the CMSystemDiscovery resource warning when the maximum schedule interval has been exceeded or the minimum not met (for minutes) and adds handling for test/set when the specified interval is greater/less than the maximum/minimum allowed.

Also adds a validaterange on the TimeSinceLastPasswordUpdateDays and TimeSinceLastLogonDays parameters.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (53f75af) into master (ce13dd6) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #80   +/-   ##
=====================================
  Coverage      97%    97%           
=====================================
  Files          35     35           
  Lines        3897   3903    +6     
=====================================
+ Hits         3806   3812    +6     
  Misses         91     91           
jeffotterpohl commented 3 years ago

I know it would be more work, any thought of going ahead and also converting the ADContainers\Include\Exclude over to the helper function Compare-MultipleCompares (example can be found in DSC_CMSoftwareDistributionComponent. This would reduce the amount of code and bring it into more of a standardized way of comparing in this resource.

jeffotterpohl commented 3 years ago

Code looks good just need to finish testing and will approve.

jeffotterpohl commented 3 years ago

Looks good and works accordingly