dsccommunity / DnsServerDsc

This module contains DSC resources for the management and configuration of Windows Server DNS Server.
MIT License
65 stars 54 forks source link

DnsRecordMx: Implemented as a class-based resource #227

Closed Sudman1 closed 3 years ago

Sudman1 commented 3 years ago

Pull Request (PR) description

Implements a class-based solution for managing MX records - to include implementation of managing scoped records.

Note: This PR also removes xDnsRecordMX to avoid conflicts.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #227 (6eee939) into main (01585ce) will decrease coverage by 4%. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #227   +/-   ##
===================================
- Coverage    90%    85%   -5%     
===================================
  Files        16     16           
  Lines      1460   1537   +77     
===================================
- Hits       1319   1318    -1     
- Misses      141    219   +78     
Impacted Files Coverage Δ
...Resources/MSFT_xDnsRecordMx/MSFT_xDnsRecordMx.psm1 0% <0%> (-99%) :arrow_down:
source/xDnsServer.psm1 99% <0%> (+<1%) :arrow_up:
johlju commented 3 years ago

@Sudman1 I saw you reused the examples, integration tests and unit tests, let's leave them as is. Just revert the code folder xDnsRecordMx and add a deprecated message in the change log.

johlju commented 3 years ago

Tracking the removal of the old resource here https://github.com/dsccommunity/xDnsServer/issues/228.

johlju commented 3 years ago

@Sudman1 seems it fails on the xDnsRecordMx unit test. You can just delete that unit test. There are no changes introduced in this PR that changes that resource, right?

johlju commented 3 years ago

...also the integration test for xDnsRecordMx can be removed... it also fails.

Sudman1 commented 3 years ago

That's correct. Thanks - you've saved me some Pester Mock troubleshooting there.