Closed johlju closed 3 years ago
Merging #247 (4e86a8b) into main (a2eedd1) will decrease coverage by
0%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #247 +/- ##
===================================
- Coverage 90% 90% -1%
===================================
Files 14 14
Lines 1514 1476 -38
===================================
- Hits 1375 1337 -38
Misses 139 139
Impacted Files | Coverage Δ | |
---|---|---|
source/DnsServerDsc.psm1 | 99% <0%> (-1%) |
:arrow_down: |
Merging this to remove old behavior from the base class so it is easier to go forward in subsequent PR's.
Pull Request (PR) description
Get()
the overload that took a[Microsoft.Management.Infrastructure.CimInstance]
was removed as it is not the correct pattern going forward.Assert()
tha callsAssert-Module
andAssertProperties()
.Assert-Module
from the constructor to a new methodAssert()
that is called fromGet()
,Test()
, andSet()
. The methodAssert()
also calls the methodAssertProperties()
. The methodAssert()
is not meant to be overridden, but can if there is a reason not to runAssert-Module
and orAssertProperties()
.This Pull Request (PR) fixes the following issues
None.
Task list
This change is