dsccommunity / DnsServerDsc

This module contains DSC resources for the management and configuration of Windows Server DNS Server.
MIT License
65 stars 54 forks source link

DnsRecordPtr: IPv6 hot fix #256

Closed Sudman1 closed 3 years ago

Sudman1 commented 3 years ago

Pull Request (PR) description

Fixed logic bug in expanding IPv6 addresses used to detect the reverse lookup zone name.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 3 years ago

Codecov Report

Merging #256 (c40c577) into main (b17d68f) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #256   +/-   ##
===================================
  Coverage    91%    91%           
===================================
  Files        38     38           
  Lines      1546   1550    +4     
===================================
+ Hits       1407   1411    +4     
  Misses      139    139           
Impacted Files Coverage Δ
source/Classes/002.DnsRecordPtr.ps1 100% <100%> (ø)
johlju commented 3 years ago

The tests could have used test cases instead of a foreach (foreach could have built the test case instead). But we can keep it as is and fix it for Pester 5 in the future.

johlju commented 3 years ago

So just that tiny fix and it will be ready to merge. 😄