dsccommunity / DscResource.Common

This module contains common functions that are used in DSC resources.
https://dsccommunity.org
MIT License
9 stars 9 forks source link

Added Public Function Find-Certificate #101

Closed hollanjs closed 1 year ago

hollanjs commented 1 year ago

Pull Request (PR) description

Moved Find-Certificate from a utility function in CertificateDsc.Common.psm1 to a public function in DscResource.Common. Related to CertificateDsc Issue #272

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #101 (ed4d7d9) into main (c5ef7be) will increase coverage by 0%. The diff coverage is 100%.

:exclamation: Current head ed4d7d9 differs from pull request most recent head 3a0111b. Consider uploading reports for the commit 3a0111b to get more accurate results

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #101   +/-   ##
===================================
  Coverage    91%    92%           
===================================
  Files        34     35    +1     
  Lines       599    628   +29     
===================================
+ Hits        550    579   +29     
  Misses       49     49           
Impacted Files Coverage Δ
source/Public/Find-Certificate.ps1 100% <100%> (ø)
johlju commented 1 year ago

I forgot about this. I have been working a lot lately so I haven't been able do much community work. Will try to look at this soon.

johlju commented 1 year ago

@hollanjs sorry for tasking so long wit this one. Just a tiny comment.