dsccommunity / DscResource.Common

This module contains common functions that are used in DSC resources.
https://dsccommunity.org
MIT License
9 stars 9 forks source link

Compare-DscParameterState: Add support for OrderedDictionary #116

Closed johlju closed 9 months ago

johlju commented 9 months ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f06681b) 91% compared to head (ed6a3e5) 91%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/116/graphs/tree.svg?width=650&height=150&src=pr&token=rlTA7BkRB3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #116 +/- ## =================================== Coverage 91% 91% =================================== Files 38 38 Lines 668 668 =================================== Hits 613 613 Misses 55 55 ``` | [Files](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [source/Public/Compare-DscParameterState.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/116?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9Db21wYXJlLURzY1BhcmFtZXRlclN0YXRlLnBzMQ==) | `80% <ø> (ø)` | |
ghost commented 8 months ago

@johlju I created a pull request to add this feature. Your change was identical to mine. It took a moment to realize this. When will this appear in the SqlServerDsc?

johlju commented 8 months ago

It is in the release 0.17.0, so when SqlServerDsc is built in its pipeline it will have it.