dsccommunity / DscResource.Common

This module contains common functions that are used in DSC resources.
https://dsccommunity.org
MIT License
9 stars 9 forks source link

Get-PSModulePath: Improve the command with Scope #120

Closed johlju closed 7 months ago

johlju commented 7 months ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

None.

Task list


This change is Reviewable

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (df361a2) 92% compared to head (d8cb9cf) 92%. Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120/graphs/tree.svg?width=650&height=150&src=pr&token=rlTA7BkRB3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #120 +/- ## =================================== Coverage 92% 92% =================================== Files 38 39 +1 Lines 668 668 =================================== Hits 621 621 Misses 47 47 ``` | [Files](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [source/Public/Get-PSModulePath.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9HZXQtUFNNb2R1bGVQYXRoLnBzMQ==) | `100% <100%> (ø)` | | | [source/Public/New-ArgumentException.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9OZXctQXJndW1lbnRFeGNlcHRpb24ucHMx) | `100% <100%> (ø)` | | | [source/Public/New-ErrorRecord.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9OZXctRXJyb3JSZWNvcmQucHMx) | `100% <100%> (ø)` | | | [source/Public/New-InvalidDataException.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9OZXctSW52YWxpZERhdGFFeGNlcHRpb24ucHMx) | `100% <100%> (ø)` | | | [source/Public/New-InvalidOperationException.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9OZXctSW52YWxpZE9wZXJhdGlvbkV4Y2VwdGlvbi5wczE=) | `100% <100%> (ø)` | | | [source/Public/New-InvalidResultException.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9OZXctSW52YWxpZFJlc3VsdEV4Y2VwdGlvbi5wczE=) | `100% <100%> (ø)` | | | [source/Public/New-NotImplementedException.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9OZXctTm90SW1wbGVtZW50ZWRFeGNlcHRpb24ucHMx) | `100% <100%> (ø)` | | | [source/Public/New-ObjectNotFoundException.ps1](https://app.codecov.io/gh/dsccommunity/DscResource.Common/pull/120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9OZXctT2JqZWN0Tm90Rm91bmRFeGNlcHRpb24ucHMx) | `100% <100%> (ø)` | |
johlju commented 7 months ago

Merging this as it should not be a breaking change, and fixes a bug.