dsccommunity / DscResource.DocGenerator

Module for generation of DSC resource documentation

MIT License

9 stars 10 forks source link

[Invoke-Git] Return Object & Change to Public Function #80

Closed phbits closed 3 years ago

phbits commented 3 years ago

Pull Request

Pull Request (PR) description

Invoke-Git
- Now a public function since Tasks can only use public functions.
- Returns an object allowing caller to take appropriate action.
- Updated tests.

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[ ] Documentation added/updated in README.md.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated.
[x] Integration tests added/updated (where possible).
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

codecov[bot] commented 3 years ago

Codecov Report

Merging #80 (4f7a2e8) into main (27e84f3) will increase coverage by 0%. The diff coverage is 100%.

@@        Coverage Diff         @@
##           main   #80   +/-   ##
==================================
  Coverage    97%   97%           
==================================
  Files        38    38           
  Lines       865   877   +12     
==================================
+ Hits        846   859   +13     
+ Misses       19    18    -1

johlju commented 3 years ago

It seems the changes did not work as expected, it failed to publish to the Wiki. See error https://dev.azure.com/dsccommunity/DscResource.DocGenerator/_build/results?buildId=4801&view=logs&j=5d0a9c4e-8741-5118-af45-406a30fe661c&t=bda0b158-a237-516f-c1d0-31339587c5b5&l=146

2021-06-19T15:25:33.0578840Z Publishing Wiki content.
2021-06-19T15:25:33.2106611Z ERROR: Exception calling "Start" with "0" argument(s): "No such file or directory"
2021-06-19T15:25:33.2107271Z At /home/vsts/work/1/s/output/DscResource.DocGenerator/0.9.0/DscResource.DocGenerator.psm1:1402 char:13
2021-06-19T15:25:33.2108430Z +         if ($process.Start() -eq $true)
2021-06-19T15:25:33.2108871Z +             ~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-06-19T15:25:33.2151472Z At /home/vsts/work/1/s/source/tasks/Publish_GitHub_Wiki_Content.build.ps1:102 char:1

johlju commented 3 years ago

Maybe this PR is needed to complete everything? 🙂

johlju commented 3 years ago

@phbits I will review this once you rebased this PR. 🙂

phbits commented 3 years ago

@phbits I will review this once you rebased this PR. 🙂

I did the rebase and had to do a force push. After manually resolving conflicts and fixing typos, this PR looks ready.

johlju commented 3 years ago

@phbits you need to rebase again since another PR was merged. 🙂