xCluster: Enabled localization

[johlju]

Pull Request (PR) description

• Changes to xFailOverCluster
  • Added common test helper functions to help test the throwing of localized error strings.
  • Get-InvalidArgumentRecord
  • Get-InvalidOperationRecord
  • Get-ObjectNotFoundException
  • Get-InvalidResultException.
• Changes to xCluster
  • Enabled localization for all strings (issue #83).
  • Added tests to improve code coverage.

This Pull Request (PR) fixes the following issues: Fixes #83

Task list:

• [x] Change details added to Unreleased section of CHANGELOG.md?
• [ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
• [ ] Examples appropriately updated?
• [x] New/changed code adheres to Style Guidelines?
• [x] Unit and (optional) Integration tests created/updated where possible?

---

This change is 

[msftclas]

@johlju, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request. Thanks, Microsoft Pull Request Bot

[codecov-io]

Codecov Report

Merging #118 into dev will increase coverage by <1%. The diff coverage is 100%.

@@         Coverage Diff         @@
##           dev   #118    +/-   ##
===================================
+ Coverage   99%   100%   +<1%     
===================================
  Files        7      7            
  Lines      381    391    +10     
===================================
+ Hits       379    391    +12     
+ Misses       2      0     -2

[johlju]

@PlagueHO do you have time to review this one for me? No hurry.

[PlagueHO]

No problem @johlju - will review tomorrow night after work (bed time now!)

Looks like build is failing though..

[johlju]

Yes. :/ Tried to improve them. They worked when I ran the tests with -Tag Helper but not when all tests ran together... trying to fix the tests now.

[johlju]

Okay, the tests work now, yay! 😄

[PlagueHO]

Looks almost perfect. Just two trivial changes.

---

Reviewed 2 of 5 files at r1, 2 of 3 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

Tests/TestHelpers/CommonTestHelper.psm1, line 18 at r3 (raw file):

        [Parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [String]

Change to System.String To be consistent with other code in the module.

---

Tests/TestHelpers/CommonTestHelper.psm1, line 23 at r3 (raw file):

        [Parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [String]

Change to System.String To be consistent with other code in the module.

---

Tests/TestHelpers/CommonTestHelper.psm1, line 63 at r3 (raw file):

        [Parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [String]

Change to System.String To be consistent with other code in the module.

---

Comments from Reviewable

[johlju]

Review status: 4 of 5 files reviewed at latest revision, 3 unresolved discussions.

---

Tests/TestHelpers/CommonTestHelper.psm1, line 18 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Change to `System.String` To be consistent with other code in the module.

Done.

---

Tests/TestHelpers/CommonTestHelper.psm1, line 23 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Change to `System.String` To be consistent with other code in the module.

Done.

---

Tests/TestHelpers/CommonTestHelper.psm1, line 63 at r3 (raw file):

Previously, PlagueHO (Daniel Scott-Raynsford) wrote…

Change to `System.String` To be consistent with other code in the module.

Done.

---

Comments from Reviewable

[PlagueHO]

---

Reviewed 1 of 1 files at r4. Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable