xCluster: Fix cluster creation on Server 2012

[codykonior]

Pull Request (PR) description

xCluster\Set-TargetResource builds a hashtable for splatting against New-Cluster. It now checks if Force is an accepted parameter on that command before adding it to the hashtable.

I added a stub of the Server 2012 version of New-Cluster named New-Cluster_NoForce which does not have the Force switch defined.

There is one applicable test, "Should call New-Cluster cmdlet". I've copied this into another block, "Should call New-Cluster cmdlet without -Force if it is not supported". This block swaps the New-Cluster stub for the New-Cluster_NoForce stub by using Set-Alias.

The test confirms that, when the Server 2012 version of New-Cluster is in place the -Force option will not be passed along.

I've tested:

• Removing my change results in the new test failing.
• Adding my change results in all tests passing.
• And that the change works for me on a Server 2012 VM.

It seems that the stub file had incorrect line endings which changed when I edited it. But you can view in VS Code etc that it's only one stub function added.

This Pull Request (PR) fixes the following issues

• Fixed #188

Task list

• [x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
• [ ] Resource documentation added/updated in README.md.
• [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
• [ ] Comment-based help added/updated.
• [ ] Localization strings added/updated in all localization files as appropriate.
• [ ] Examples appropriately added/updated.
• [x] Unit tests added/updated. See DSC Resource Testing Guidelines.
• [ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• [ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[msftclas]

All CLA requirements met.

[codecov-io]

Codecov Report

Merging #189 into dev will not change coverage. The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #189   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         8      8           
  Lines       486    487    +1     
===================================
+ Hits        486    487    +1

[codykonior]

I've generated the stub for Server 2012 and then modified each test file to run twice - once against the 2012 stub and once against 2016. Getting the quorum tests to pass on 2012 required some additional fixes to the xClusterQuorum resource to use 2012 compatible aliases.

In the tests there's a new global:moduleVersion. This is because having all of the tests inside the InModuleScope block hides that variable and it is not possible to access it in any other way. That variable is needed within the tests to:

• Label the Describe blocks with the version number so that the Pester output is clear.
• Switch between different parameter filters within some of the Quorum tests. These filters operate against the parameter name and don't support the 2012 compatible aliases.
• Skip one version of the Quorum test that uses a Cloud (not applicable to 2012).

[codykonior]

Style changes submitted.