xClusterNetwork: Fix xClusterNetwork errors for Windows Server 2012

[codykonior]

Pull Request (PR) description

Wraps calls to the Update method on cluster network options in a test confirming that the method exists. The method doesn't exist on Windows Server 2012 because changing the object automatically updates. Not fixing it results in an error.

Tests have been added which change the mock on 2012 to not have an Update method. Then the tests are compared against 0 calls versus whatever number of calls is there for 2016.

This Pull Request (PR) fixes the following issues

• Fixes #191

Task list

• [x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
• [ ] Resource documentation added/updated in README.md.
• [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
• [ ] Comment-based help added/updated.
• [ ] Localization strings added/updated in all localization files as appropriate.
• [ ] Examples appropriately added/updated.
• [x] Unit tests added/updated. See DSC Resource Testing Guidelines.
• [ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• [ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #192 into dev will not change coverage. The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #192   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         8      8           
  Lines       487    493    +6     
===================================
+ Hits        487    493    +6

[johlju]

@codykonior Thanks for this! I will review this as soon as I can. I'm away this weekend so if I can't get to it during the weekend, I will get to it next week. 🙂

[codykonior]

Style changes and variable rename done.

[codykonior]

I remember you saying you were travelling. Gentle reminder that this is ready for review again.

[johlju]

@codykonior I have this on my todo - will try to get to it tonight. 🙂

[johlju]

@codykonior Have to push this to later this weekend. Sorry for the delay. 😞

[codykonior]

In defense of psobject, it's documented and used in PowerShell Core and other DSC Resources with no indication it's going anywhere.

But I know some people prefer PowerShell conventions to .NET style ones and I could make the change easily so I've done so.

MemberType Method didn't work well because the mocks are a ScriptMethod type. However it appears there's a MemberType property of Methods which covers both so that's what I used.