dsccommunity / FailoverClusterDsc

This module contains DSC resources for deployment and configuration of Windows Server Failover Cluster.

MIT License

60 stars 54 forks source link

BREAKING CHANGE: xFailOverCluster renamed to FailoverClusterDsc: Renamed all DSCResources, Examples, Modules and Tests where applicable #264

Closed nickgw closed 2 years ago

nickgw commented 2 years ago

Pull Request (PR) description

Rename module to FailoverClusterDsc from xFailOverCluster

This Pull Request (PR) fixes the following issues

Fixes #69

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

codecov[bot] commented 2 years ago

Codecov Report

Merging #264 (628cb9b) into main (4aafd66) will not change coverage. The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #264   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         7      7           
  Lines       458    458           
===================================
  Hits        458    458

johlju commented 2 years ago

@nickgw can you send in anther PR deprecating the previous module? Just change the CHANGELOG.md under the Unreleased section:

   ### Deprecated

   **The module _xFailOverCluster_ will be renamed _FailoverClusterDsc_ ([issue #69](https://github.com/dsccommunity/xFailOverCluster/issues/69)).
   The version `v1.6.1` will be the the last release of _xFailOverCluster_.
   The Version `v2.0.0` will be release as _FailoverClusterDsc_, it will be
   released shortly after the `v1.6.1` release to easily transition to the
   new module.** The prefix 'x' will be removed from all resources in
   _FailoverClusterDsc_.

I will then push a last release of xFailOverCluster before we merge this PR.

johlju commented 2 years ago

@nickgw can you send in anther PR deprecating the previous module? Just change the CHANGELOG.md under the Unreleased section:
### Deprecated

**The module _xFailOverCluster_ will be renamed _FailoverClusterDsc_ ([issue #69](https://github.com/dsccommunity/xFailOverCluster/issues/69)).
The version `v1.6.1` will be the the last release of _xFailOverCluster_.
The Version `v2.0.0` will be release as _FailoverClusterDsc_, it will be
released shortly after the `v1.6.1` release to easily transition to the
new module.** The prefix 'x' will be removed from all resources in
_FailoverClusterDsc_.
I will then push a last release of xFailOverCluster before we merge this PR.

I can fix this myself now, got a few minutes over.

johlju commented 2 years ago

@nickgw awesome work on this, thank you!

johlju commented 2 years ago

This is ready for merge as soon as PR #265 has been merged and a full release has been made for xFailOverCluster. After that, before merge, we need to

rename the pipeline to the correct name
rename the GitHub repo
update branch rules (status checks) in GitHub
...possible other things I can see now. 🙂

johlju commented 2 years ago

So everything should be prepared behind the scenes so we can merge this. I will do that later today.