dsccommunity / FailoverClusterDsc

This module contains DSC resources for deployment and configuration of Windows Server Failover Cluster.

MIT License

60 stars 54 forks source link

README.md: Fixed CodeCov badge links #66

Closed johlju closed 7 years ago

johlju commented 7 years ago

Pull Request (PR) description

Changes to README.md
- Fixed CodeCov badge links so they now can be clicked on.

This Pull Request (PR) fixes the following issues: None

Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[x] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

msftclas commented 7 years ago

@johlju, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request. Thanks, Microsoft Pull Request Bot

johlju commented 7 years ago

@bgelens Embarrassing but I messed up the codecov badge links. Could you review this one when you got a chance?

Did the same error in xSQLServer too... Didn't learn ;)

bgelens commented 7 years ago

Oh no! I missed those as well :)

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

codecov-io commented 7 years ago

Codecov Report

Merging #66 into dev will not change coverage. The diff coverage is n/a.

@@        Coverage Diff        @@
##           dev   #66   +/-   ##
=================================
  Coverage   57%   57%           
=================================
  Files        6     6           
  Lines      293   293           
=================================
  Hits       168   168           
  Misses     125   125

johlju commented 7 years ago

Tiny little characters those '>' 😉