dsccommunity / FailoverClusterDsc

This module contains DSC resources for deployment and configuration of Windows Server Failover Cluster.

MIT License

60 stars 54 forks source link

xFailOverCluster: Added VS Code workspace settings file #68

Closed johlju closed 7 years ago

johlju commented 7 years ago

Pull Request (PR) description

Changes to xFailOverCluster
- Added VS Code workspace settings file with formatting settings matching the Style Guideline (issue #67). That will make it possible inside VS Code to press SHIFT+ALT+F, or press F1 and choose 'Format document' in the list. The PowerShell code will then be formatted according to the Style Guideline (although maybe not complete, but would help a long way).

This Pull Request (PR) fixes the following issues: Fixes #67

Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[x] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

msftclas commented 7 years ago

@johlju, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request. Thanks, Microsoft Pull Request Bot

codecov-io commented 7 years ago

Codecov Report

Merging #68 into dev will not change coverage. The diff coverage is n/a.

@@        Coverage Diff        @@
##           dev   #68   +/-   ##
=================================
  Coverage   57%   57%           
=================================
  Files        6     6           
  Lines      293   293           
=================================
  Hits       168   168           
  Misses     125   125

johlju commented 7 years ago

@bgelens If you want to review this one whenever you have a chance. No hurry.

Btw. It seems that we can't protect our self from changes to the settings.json file with the .gitignore file. Once a file is indexed it .gitignore will, well, ignore it ;) So if a contributor makes a change to the settings.json it will be included into the PR unfortunately (and we have to handle that in the review). But all new files in the .vscode folder will be ignore as long as .vscode is in the .gitignore file.

johlju commented 7 years ago

@bgelens Updated this PR according to https://github.com/PowerShell/DscResources/issues/284#issuecomment-312422210

bgelens commented 7 years ago

Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

.vscode/settings.json, line 1 at r2 (raw file):

// Place your settings in this file to overwrite default and user settings.

OK. Personally I would remove this comment

Comments from Reviewable

johlju commented 7 years ago

Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion.

.vscode/settings.json, line 1 at r2 (raw file):

Previously, bgelens (Ben Gelens) wrote…

OK. Personally I would remove this comment

Done.

Comments from Reviewable

johlju commented 7 years ago

Reviewed 1 of 2 files at r1, 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

bgelens commented 7 years ago

Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable