dsccommunity / HyperVDsc

This module contains DSC resources for deployment and configuration of Microsoft Hyper-V.
MIT License
114 stars 65 forks source link

xVhdFileDirectory Unit Tests #180

Closed dacarab closed 4 years ago

dacarab commented 4 years ago

Pull Request (PR) description

PR that adds some basic initial unit tests for the xVhdFileDirectory resource. There is a bug that I'd like to fix around copying to VHDs with multiple partitions - before I look into that, I'd like to put some unit tests in place.

I have not covered off tests for any of the private functions within the resource as of yet, as I may propose to change a couple.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #180 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #180   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        11     11           
  Lines      1401   1401           
===================================
  Hits       1166   1166           
  Misses      235    235
johlju commented 4 years ago

@mcollera or @aromano2 you are listed as maintainers for this module. Do you have time to review this one?

aromano2 commented 4 years ago

@johlju yes looking at it now, thanks!