dsccommunity / HyperVDsc

This module contains DSC resources for deployment and configuration of Microsoft Hyper-V.
MIT License
114 stars 65 forks source link

BREAKING CHANGE: xHyper-V renamed to HyperVDsc: Renamed all DSCResources, Examples, Modules and Tests where applicable #194

Closed nickgw closed 2 years ago

nickgw commented 2 years ago

Pull Request (PR) description

BREAKING CHANGE: xHyper-V renamed to HyperVDsc: Renamed all DSCResources, Examples, Modules and Tests where applicable

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #194 (55e3116) into master (77822fb) will increase coverage by 9%. The diff coverage is 83%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #194    +/-   ##
======================================
+ Coverage      73%    83%    +9%     
======================================
  Files          11     11            
  Lines        1401   1435    +34     
======================================
+ Hits         1035   1200   +165     
+ Misses        366    235   -131     
Impacted Files Coverage Δ
...ces/DSC_VMNetworkAdapter/DSC_VMNetworkAdapter.psm1 47% <50%> (ø)
...rce/Modules/HyperVDsc.Common/HyperVDsc.Common.psm1 86% <79%> (ø)
source/DSCResources/DSC_VMSwitch/DSC_VMSwitch.psm1 85% <82%> (ø)
source/DSCResources/DSC_VMHyperV/DSC_VMHyperV.psm1 85% <83%> (ø)
...ces/DSC_VhdFileDirectory/DSC_VhdFileDirectory.psm1 89% <91%> (ø)
source/DSCResources/DSC_VHD/DSC_Vhd.psm1 96% <92%> (ø)
...urces/DSC_VMHardDiskDrive/DSC_VMHardDiskDrive.psm1 89% <95%> (ø)
...ce/DSCResources/DSC_VMDvdDrive/DSC_VMDvdDrive.psm1 98% <97%> (ø)
source/DSCResources/DSC_VMHost/DSC_VMHost.psm1 100% <100%> (ø)
.../DSCResources/DSC_VMProcessor/DSC_VMProcessor.psm1 100% <100%> (ø)
... and 4 more
nickgw commented 2 years ago

@johlju while I've got your attention, idk if you saw this!

johlju commented 2 years ago

Will look at it when I have some time. 😊

johlju commented 2 years ago

@nickgw just a few tiny comments. 🙂

nickgw commented 2 years ago

@nickgw just a few tiny comments. 🙂 I'm not 100% on your first comment. I pulled azure-pipelines.yml from another repo that was updated more recently. I don't know if something changed concerning wuauserv in W2022 that changes that behavior.

I've updated the other two comments though.

johlju commented 2 years ago

Okey then I think you can safely remove the task in azure-pipelines.yml in this repo as it was not used prior. Guessing that was needed in the other repo to run a certain test.

nickgw commented 2 years ago

Okey then I think you can safely remove the task in azure-pipelines.yml in this repo as it was not used prior. Guessing that was needed in the other repo to run a certain test.

Removed!

johlju commented 2 years ago

I updated pipeline files and added resource README files to enable Wiki documentation. @nickgw can you rebase this when you have a chance?

johlju commented 2 years ago

@nickgw suggest you take azure-pipelines.yml from branch master and paste in into this PR. It will clear everything up I think.

johlju commented 2 years ago

You currently have the code coverage steps twice in the one in this PR. 🤔 So above suggestion might just be the easiest to fix it.. 🙂

johlju commented 2 years ago

@nickgw awesome work on this, thank you! I waiting for the API key then I merge this.