dsccommunity / HyperVDsc

This module contains DSC resources for deployment and configuration of Microsoft Hyper-V.
MIT License
111 stars 65 forks source link

Add inclusion in Hyper-V cluster #210

Open nyanhp opened 1 year ago

nyanhp commented 1 year ago

Pull Request (PR) description

Attempting to add cluster-awareness. Was unable to get a local build to run on (and found no info how to do it):

While the added code worked in my own lab and on site in the customer environment, I have no idea if tests will work, as some test cases for other resources randomly kept failing. So, apologies in advance. As a suggestion, a little 'How-to run a local build' would be appreciated.

Adding VMs to a cluster requires usage of PsDscRunAsCredential.

This Pull Request (PR) fixes the following issues

None

Task list


This change is Reviewable

nyanhp commented 1 year ago

All tests successfully passed, code coverage could not be reported

codecov[bot] commented 1 year ago

Codecov Report

Merging #210 (ac7b58a) into main (6c0e583) will increase coverage by 0%. Report is 1 commits behind head on main. The diff coverage is 90%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/HyperVDsc/pull/210/graphs/tree.svg?width=650&height=150&src=pr&token=hmc2bLthmd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/HyperVDsc/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #210 +/- ## =================================== Coverage 83% 83% =================================== Files 11 11 Lines 1441 1464 +23 =================================== + Hits 1203 1223 +20 - Misses 238 241 +3 ``` | [Files](https://app.codecov.io/gh/dsccommunity/HyperVDsc/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [...ce/DSCResources/DSC\_VMDvdDrive/DSC\_VMDvdDrive.psm1](https://app.codecov.io/gh/dsccommunity/HyperVDsc/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9EU0NfVk1EdmREcml2ZS9EU0NfVk1EdmREcml2ZS5wc20x) | `98% <100%> (ø)` | | | [...rce/Modules/HyperVDsc.Common/HyperVDsc.Common.psm1](https://app.codecov.io/gh/dsccommunity/HyperVDsc/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL01vZHVsZXMvSHlwZXJWRHNjLkNvbW1vbi9IeXBlclZEc2MuQ29tbW9uLnBzbTE=) | `85% <100%> (-2%)` | :arrow_down: | | [source/DSCResources/DSC\_VMHyperV/DSC\_VMHyperV.psm1](https://app.codecov.io/gh/dsccommunity/HyperVDsc/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9EU0NfVk1IeXBlclYvRFNDX1ZNSHlwZXJWLnBzbTE=) | `85% <88%> (+<1%)` | :arrow_up: |
gaelcolas commented 1 year ago

Looks like I came here after you fixed all your issues. HQRM tests are failing because of those 2 lines... Just strings missing from string files, it seems.

https://dev.azure.com/dsccommunity/HyperVDsc/_build/results?buildId=7844&view=logs&j=47266b63-9d03-5281-d38b-75133a4264f6&t=4d8b314c-6b76-5ae4-aed5-2779b7a3afdb&l=748

https://dev.azure.com/dsccommunity/HyperVDsc/_build/results?buildId=7844&view=logs&j=47266b63-9d03-5281-d38b-75133a4264f6&t=4d8b314c-6b76-5ae4-aed5-2779b7a3afdb&l=412