dsccommunity / OfficeOnlineServerDsc

This module contains DSC resources for deployment and configuration of Office Online Server.

MIT License

15 stars 16 forks source link

Updated AppVeyor #23

Closed NikCharlebois closed 6 years ago

NikCharlebois commented 6 years ago

Updated AppVeyor to point to the DSCResources.Tests repo

[ ] Change details added to Unreleased section of changelog.md?
[ ] Added/updated documentation and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to [Style Guidelines]?(https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md)?
[ ] Unit and Integration tests created/updated where possible?

This change is

codecov-io commented 6 years ago

Codecov Report

Merging #23 into dev will not change coverage. The diff coverage is n/a.

@@        Coverage Diff        @@
##           dev   #23   +/-   ##
=================================
  Coverage   91%   91%           
=================================
  Files        4     4           
  Lines      215   215           
=================================
  Hits       197   197           
  Misses      18    18

johlju commented 6 years ago

@NikCharlebois I think you should change the code that loads the tests, and change so that it ignores testing DscResource.Tests\Tests folder.

johlju commented 6 years ago

Remove '*DscResource.Tests\Tests\*' here (I think)

https://github.com/PowerShell/OfficeOnlineServerDsc/blob/181d5a7b7d1fbba182b9fad7d57fc7c2f9d87dad/Tests/TestHarness.psm1#L69-L71

johlju commented 6 years ago

Reviewed 1 of 1 files at r1, 14 of 14 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

johlju commented 6 years ago

Why didn't it run the test on the last commit? Close and reopen to push the tests again?