dsccommunity / OfficeOnlineServerDsc

This module contains DSC resources for deployment and configuration of Office Online Server.
MIT License
15 stars 16 forks source link

OfficeOnlineServerInstall: Resource does not handle exit code 3010 (ERROR_SUCCESS_REBOOT_REQUIRED) properly #46

Closed ykuijs closed 4 years ago

ykuijs commented 5 years ago

Details of the scenario you tried and the problem that is occurring

The setup can exit with exit code 3010 (ERROR_SUCCESS_REBOOT_REQUIRED). The SPInstall resource does not handle this exit code properly: It throws an error instead of initiating a reboot.

Verbose logs showing the problem

Suggested solution to the issue

Add exit code 3010 to the list of exit codes and initiate the reboot.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

N/A

The operating system the target node is running

Windows Server 2016

Version and build of PowerShell the target node is running

v5.1

Version of the DSC module that was used ('dev' if using current dev branch)

dev

ykuijs commented 5 years ago

Will submit a PR shortly