OfficeOnlineServerFarm: Added hierarchy and LDAP:// support for FarmOU

jensotto commented 3 years ago

Pull Request (PR) description

Added support for specifying LDAP:// syntax and OU hierarchy for FarmOU

It's now possible to specify FarmOU like this:

"Servers/OOS" or "ldap://OU=OOS,OU=Servers"

ntds:// format is supported by the underlying Office Online Server Management Shell but is not implemented in OfficeOnlineServerDSC.

This Pull Request (PR) fixes the following issues

Fixes #58

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[x] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

jensotto commented 3 years ago

@ykuijs Will it be possible to include this improvement anytime soon?

codecov[bot] commented 12 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

jensotto commented 12 months ago

Sorry @johlju I don't have the environment for this available anymore. I don't expect that I will be able to contribute much to this right now as my focus is elsewhere. All I can say is that the changes worked fine in a manually edited version of this module with the suggested changes on the server used for OOS.

johlju commented 11 months ago

No worries, I understand. I will label this as abandond so another contributor can take over to verify this. I'm sure the code worked for you in your scenario, but I worried it will break existing configurations in other scenarios.

dsccommunity / OfficeOnlineServerDsc