CipherSuites: Draft fix issue #33

holentommy commented 1 year ago

Attempting to resolve issue 'CipherSuites: Using 'Absent' for named CipherSuites on default installations does not work. #33'

Pull Request (PR) description

Utilizing Get-TlsCiperSuite, Enable-TlsCiperSuite, and Disable-TlsCipherSuite for Windows Server 2016 and newer. For Windows Server 2012 R2 and older, using registry but if 'HKLM:\SOFTWARE\Policies\Microsoft\Cryptography\Configuration\SSL\00010002:Functions' isn't set utilize 'HKLM:\SYSTEM\CurrentControlSet\Control\Cryptography\Configuration\Local\SSL\00010002:Functions' for Get-TargetResource.

This Pull Request (PR) fixes the following issues

Fixes #33

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[ ] New/changed code adheres to DSC Community Style Guidelines.

This change is

johlju commented 1 year ago

I can send in a PR this weekend that resolves the build pipeline. It is using the wrong VM image.

johlju commented 1 year ago

The build and test pipeline should work now.

johlju commented 1 year ago

The tests are failing for CipherSuites.

holentommy commented 1 year ago

The tests are failing for CipherSuites.

I'll have a look.

ykuijs commented 1 year ago

There are two issues:

The High Quality Resource Module (HQRM) tests are failing because you aren't following the code guidelines. Check this log and search for "[-]" to see the failing rules
The unit tests are failing for the Cipher Suite resource. You can run these tests locally as well, by running the following command in the root of your local clone .\build.ps1 -Tasks Test

ykuijs commented 1 year ago

Almost there with the HQRM tests, there are a few open braces that are placed behind the statement but should be placed on a new line: Log file

ykuijs commented 1 year ago

@holentommy All failing HQRM tests are now resolved. That just leaves the failing unit tests. Please the this log and search for "[-]" to see which tests are failing and fix them.

FYI: You can run (and troubleshoot) the tests locally by running the following command in your local clone: .\build.ps1 -ResolveDependency -Tasks Build, Test

holentommy commented 1 year ago

I have not had the time to follow this up, will do as soon as there is more time.

dsccommunity / SChannelDsc