dsccommunity / SharePointDsc

The SharePointDsc PowerShell module provides DSC resources that can be used to deploy and manage a SharePoint farm
MIT License
245 stars 107 forks source link

SPWebApplication: Use of SecureSocketsLayer Parameter #1395

Closed ChristophHannappel closed 2 years ago

ChristophHannappel commented 2 years ago

Pull Request (PR) description

Fixed an issue where the Set method tried to use the Parameter SecureSocketsLayer with Set-SPWebApplication on SharePoint Server older than Subscription Edition.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

ykuijs commented 2 years ago

Hi @ChristophHannappel, The SecureSocketsLayer parameter also existed pre-Subscription Edition, but then didn't configure IIS like Subscription Edition is now able to. But it did configure the HTTPS host header names, etc. So I think this PR will break those scenarios.

ykuijs commented 2 years ago

Correction. Added more details and explanation to issue #1394. Will review this PR

ykuijs commented 2 years ago

Why did you close this PR??

ChristophHannappel commented 2 years ago

yeah, in an attempt to clean up my fork repo - i deleted the wrong branches :( which than closed the pull request. Unfortunately there was no warning from the github ui about an open pull request. I'll recreate it tomorrow, sorry for the confusion.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1395 (878fe84) into master (46ebecc) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1395   +/-   ##
======================================
  Coverage      84%     84%           
======================================
  Files         143     143           
  Lines       22285   22285           
======================================
+ Hits        18815   18817    +2     
+ Misses       3470    3468    -2     
Impacted Files Coverage Δ
...s/MSFT_SPWebApplication/MSFT_SPWebApplication.psm1 94% <100%> (ø)
...s/MSFT_SPInstallPrereqs/MSFT_SPInstallPrereqs.psm1 88% <0%> (+<1%) :arrow_up: