search

dsccommunity / SharePointDsc

The SharePointDsc PowerShell module provides DSC resources that can be used to deploy and manage a SharePoint farm
MIT License
245 stars 107 forks source link

SPDistributedCacheClientSetting: Missing SP2019 and SE Values #1399

Closed ChristophHannappel closed 1 year ago

ChristophHannappel commented 2 years ago

Problem description

The Ressource is missing the SP2019 and SPSE specific container Settings:

They are documented at SharePoint Server Subscription Edition and SharePoint Server 2019 PowerShell script

I'm happy to create a pull request, after I've done my other tasks :)

Verbose logs

N/A

DSC configuration

N/A

Suggested solution

Add the SP2019/SE specific Container like it has been done with SP2016

SharePoint version and build

N/A

Operating system the target node is running

N/A

PowerShell version and build the target node is running

N/A

SharePointDsc version

5.1.0
ykuijs commented 2 years ago

Perfect, it is all yours! Just two comments:

ykuijs commented 2 years ago

Hi @ChristophHannappel, any idea when you are able to fix this issue?

ChristophHannappel commented 2 years ago

Hi @ykuijs since its mostly copy and paste ill think i can create a pull request until 20. May.

ChristophHannappel commented 2 years ago

For documentation purposes - I've compared the valid values for the ContainerType Parameter of the Get-SPDistributedCacheClientSetting between SharePoint Server 2016, 2019 and Subscription Edition. The new Cache Container are:

@ykuijs The Cache DistributedClientSideAppUpdateTimeCache is not mentioned in the Script "SharePoint Server Subscription Edition and SharePoint Server 2019 PowerShell script" so I'm missing an abbreviation for the variable names. Based on the syntax of the existing variables my proposal is: DCSAUTC Does this work for you or do you have a different one?

ChristophHannappel commented 2 years ago

Also the Script example uses the variable DHSC twice. First for DistributedHealthScoreCache than later again for DistributedUnifiedAuditCache - which seems like a copy and paste error

#DistributedUnifiedAuditCache
$DHSC = Get-SPDistributedCacheClientSetting -ContainerType DistributedUnifiedAuditCache
$DHSC.MaxConnectionsToServer = 1
$DHSC.requestTimeout = "3000"
$DHSC.channelOpenTimeOut = "3000"
Set-SPDistributedCacheClientSetting -ContainerType DistributedUnifiedAuditCache $DHSC

Based on the naming scheme my proposal is DUAuC for DistributedUnifiedAuditCache since DUAC is already used for DistributedUnifiedAppsCache