search

dsccommunity / SharePointDsc

The SharePointDsc PowerShell module provides DSC resources that can be used to deploy and manage a SharePoint farm
MIT License
247 stars 107 forks source link

Wiki Resource overview: Formatting issue with credssp column #1405

Closed bartvermeersch closed 2 years ago

bartvermeersch commented 2 years ago

Removed extra empty cell.

This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1405 (5a47b3e) into master (df57d18) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1405   +/-   ##
======================================
  Coverage      84%     84%           
======================================
  Files         143     143           
  Lines       22377   22377           
======================================
  Hits        18901   18901           
  Misses       3476    3476
ykuijs commented 2 years ago

Hi @bartvermeersch, good spot! Could you do me favor though: The pipeline is failing because this PR does not contain an updated changelog, which is required so all changes are properly documented.

Could you please add the following lines to the Fixed block in the Unreleased section (at the top of the list):

- SharePointDsc
  - Fixed incorrect table formatting in the resource table of the Wiki
bartvermeersch commented 2 years ago

I'm not sure where to add it ...

Is it in a file or my initial comment? thanks

ykuijs commented 2 years ago

The repository contains a Changelog.md file: https://github.com/dsccommunity/SharePointDsc/blob/master/CHANGELOG.md

Then add it here: image