dsccommunity / SharePointDsc

The SharePointDsc PowerShell module provides DSC resources that can be used to deploy and manage a SharePoint farm
MIT License
245 stars 107 forks source link

SPTrustedRootAuthority - Fix Error while adding Trusted Root Authority via CertificateThumbprint #1418

Closed hollanjs closed 1 year ago

hollanjs commented 1 year ago

Pull Request (PR) description

Added -Recurse to Get-ChildItem when Set-TargetResource attempts to obtain reference to the certificate by thumbprint.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

hollanjs commented 1 year ago

I've submitted an issue with the CertificateDsc module to move the Find-Certificate function to the DSCResource.Common module. This should allow a better refactoring of the SP resources that need to obtain references to certificates in the local machine, as well as reduce the amount of code and tests that need to be maintained and updated here.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1418 (c4cf42f) into master (e294818) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1418   +/-   ##
======================================
  Coverage      84%     84%           
======================================
  Files         145     145           
  Lines       22645   22645           
======================================
+ Hits        19074   19076    +2     
+ Misses       3571    3569    -2     
Impacted Files Coverage Δ
...stedRootAuthority/MSFT_SPTrustedRootAuthority.psm1 88% <100%> (ø)
...s/MSFT_SPInstallPrereqs/MSFT_SPInstallPrereqs.psm1 88% <0%> (+<1%) :arrow_up: