dsccommunity / SharePointDsc

The SharePointDsc PowerShell module provides DSC resources that can be used to deploy and manage a SharePoint farm
MIT License
247 stars 107 forks source link

Fixes Compare-Object Exception if there are currently no CertificateN… #1437

Closed ChristophHannappel closed 7 months ago

ChristophHannappel commented 7 months ago

Pull Request (PR) description

Fixes an Issue where the Ressource Get-SPCertificateSettings fails when setting SPCertificateNotificationContact and there are currently none set.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84%. Comparing base (c8281f1) to head (b310e7d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/SharePointDsc/pull/1437/graphs/tree.svg?width=650&height=150&src=pr&token=pEGO3aoxXm&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/SharePointDsc/pull/1437?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## master #1437 +/- ## ====================================== - Coverage 84% 84% -1% ====================================== Files 145 145 Lines 22805 22809 +4 ====================================== + Hits 19234 19236 +2 - Misses 3571 3573 +2 ``` | [Files](https://app.codecov.io/gh/dsccommunity/SharePointDsc/pull/1437?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [...ertificateSettings/MSFT\_SPCertificateSettings.psm1](https://app.codecov.io/gh/dsccommunity/SharePointDsc/pull/1437?src=pr&el=tree&filepath=SharePointDsc%2FDSCResources%2FMSFT_SPCertificateSettings%2FMSFT_SPCertificateSettings.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-U2hhcmVQb2ludERzYy9EU0NSZXNvdXJjZXMvTVNGVF9TUENlcnRpZmljYXRlU2V0dGluZ3MvTVNGVF9TUENlcnRpZmljYXRlU2V0dGluZ3MucHNtMQ==) | `100% <100%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/dsccommunity/SharePointDsc/pull/1437/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)