dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.

MIT License

360 stars 227 forks source link

SqlSetup: SourcePath should be a mandatory parameter #1756

Closed jrdbarnes closed 2 years ago

jrdbarnes commented 2 years ago

Pull Request (PR) description

SourcePath should be a mandatory parameter on the *-TargetResource functions, as an exception is thrown if the parameter is not passed.

This Pull Request (PR) fixes the following issues

Fixes #1755

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[ ] Resource documentation updated in the resource's README.md.
[x] Resource parameter descriptions updated in schema.mof.
[ ] Comment-based help updated, including parameter descriptions.
[ ] Localization strings updated.
[ ] Examples updated.
[ ] Unit tests updated. See DSC Community Testing Guidelines.
[ ] Integration tests updated (where possible). See DSC Community Testing Guidelines.
[x] Code changes adheres to DSC Community Style Guidelines.

This change is

codecov[bot] commented 2 years ago

Codecov Report

Merging #1756 (3e2daef) into main (d6eebb5) will not change coverage. The diff coverage is n/a.

@@         Coverage Diff          @@
##           main   #1756   +/-   ##
====================================
  Coverage    87%     87%           
====================================
  Files        38      38           
  Lines      6348    6348           
====================================
  Hits       5574    5574           
  Misses      774     774

Flag	Coverage Δ
unit	`87% <ø> (ø)`

Impacted Files	Coverage Δ
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1	`98% <ø> (ø)`