search

dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 227 forks source link

SqlDatabasePermission: The complex type `DatabasePermission` should be renamed to not conflict #1777

Closed johlju closed 1 year ago

johlju commented 2 years ago

The complex type that is used by the resource SqlDatabasePermission is named DatabasePermission.

https://github.com/dsccommunity/SqlServerDsc/blob/6c735eac2852802c5e48bcd61acbeb22f9d1ed0e/source/Classes/002.DatabasePermission.ps1#L35

Since the class is registered in the namespace root/Microsoft/Windows/DesiredStateConfiguration I suggest we rename it that is less likely to conflict with other DSC resources.

We could rename it to SqlDscDatabasePermission. Other name suggestions?

johlju commented 2 years ago

The rename need to be carried out throughout private, public, classes and tests.

johlju commented 2 years ago

We should do this rename before releasing next major release.

johlju commented 2 years ago

Optional names to consider for DatabasePermission:

johlju commented 1 year ago

Since this is already out in the wild I'm closing this until it is a problem.