dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 227 forks source link

SqlServerDsc: Resources work with SqlServer v22.0.49-preview #1808

Closed johlju closed 1 year ago

johlju commented 2 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

None.

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1808 (e830ee7) into main (bed3b12) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1808   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        71      71           
  Lines      7272    7303   +31     
====================================
+ Hits       6620    6654   +34     
+ Misses      652     649    -3     
Flag Coverage Δ
unit 91% <100%> (+<1%) :arrow_up:
Impacted Files Coverage Δ
source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1 99% <100%> (+<1%) :arrow_up:
...sources/DSC_SqlReplication/DSC_SqlReplication.psm1 65% <100%> (+3%) :arrow_up:
...urce/DSCResources/DSC_SqlScript/DSC_SqlScript.psm1 96% <100%> (+<1%) :arrow_up:
...sources/DSC_SqlScriptQuery/DSC_SqlScriptQuery.psm1 96% <100%> (+<1%) :arrow_up:
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 98% <100%> (+<1%) :arrow_up:
johlju commented 2 years ago

This attempt to use latest preview version of SqlServer didn't fair well with the integration tests.

github-actions[bot] commented 1 year ago

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

johlju commented 1 year ago

This PR now uses dbatools, to see if that works.

johlju commented 1 year ago

Dbatools is missing the assemblies for Analysis Services.

PowerShell DSC resource DSC_SqlSetup  failed to execute Test-TargetResource functionality with error message: System.InvalidOperationException: Failed to connect to Analysis Services instance 'APPVEYOR-VM\DSCMULTI'. 
(SQLCOMMON0021) ---> System.Management.Automation.PSArgumentException: Cannot find type [Microsoft.AnalysisServices.Server]: verify that the assembly containing this type is loaded.
   at System.Management.Automation.MshCommandRuntime.ThrowTerminatingError(ErrorRecord errorRecord)
   --- End of inner exception stack trace --- 
    + CategoryInfo          : InvalidOperation: (root/Microsoft/...gurationManager:String) [], CimException
    + FullyQualifiedErrorId : ProviderOperationExecutionFailure
    + PSComputerName        : localhost
johlju commented 1 year ago

A new preview version of SQL Server was just released, reverting to testing that.

johlju commented 1 year ago

PoC of using SqlServer v22.0.49 is done, all tests pass. There are some breaking changes in v22 that need to be addressed a bit cleaner. Need to add an optional Encrypt parameter to SqlRS, SqlScript and SqlSciptQuery.