dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 227 forks source link

Assert-ElevatedUser: Function moved to DscResource.Common Module #1815

Closed hollanjs closed 1 year ago

hollanjs commented 1 year ago

Pull Request (PR) description

Moved Assert-ElevatedUser from a private function in SqlServerDsc to a public function in DscResource.Common Related Issue adding function to DscResource.Common: Issue #82

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

hollanjs commented 1 year ago

@johlju - My PR for issue #1797. Let me know if it requires any additional updates or changes.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1815 (de89f0b) into main (6c0e426) will increase coverage by 0%. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1815   +/-   ##
====================================
  Coverage    88%     88%           
====================================
  Files        83      82    -1     
  Lines      7444    7437    -7     
====================================
- Hits       6594    6588    -6     
+ Misses      850     849    -1     
Flag Coverage Δ
unit 88% <ø> (+<1%) :arrow_up:
johlju commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
johlju commented 1 year ago

I'm trying to figure out why the build fails. It has nothing to do with this PR. Probably an issue on the build worker as Azure Pipelines shifted linux version.

johlju commented 1 year ago

@hollanjs great work on this. Much appreciated to gotten this command moved! 🙇