dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 227 forks source link

SqlAGReplica: Converted unit tests to Pester 5 #1820

Closed johlju closed 1 year ago

johlju commented 1 year ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

johlju commented 1 year ago

I converted the tests for Get so far. The rest are coming in other commits.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1820 (c3b7b2e) into main (d5692e2) will increase coverage by 2%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           main   #1820    +/-   ##
=====================================
+ Coverage    88%     90%    +2%     
=====================================
  Files        82      82            
  Lines      7437    7437            
=====================================
+ Hits       6588    6737   +149     
+ Misses      849     700   -149     
Flag Coverage Δ *Carryforward flag
unit 90% <100%> (+2%) :arrow_up: Carriedforward from bee3ad5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...SCResources/DSC_SqlAGReplica/DSC_SqlAGReplica.psm1 75% <100%> (+75%) :arrow_up:
johlju commented 1 year ago

Converted Set-TargetResource. I will convert Test-TargetResource tomorrow.