Test-IsNumericType: Function moved to DscResource.Common Module

[hollanjs]

Pull Request (PR) description

Moved Test-IsNumericType from a private function in SqlServerDsc to a public function in DscResource.Common Related Issue adding function to DscResource.Common: Issue #87

This Pull Request (PR) fixes the following issues

• Fixes #1795

Task list

• [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
• [ ] Resource documentation updated in the resource's README.md.
• [ ] Resource parameter descriptions updated in schema.mof.
• [ ] Comment-based help updated, including parameter descriptions.
• [ ] Localization strings updated.
• [ ] Examples updated.
• [x] Unit tests updated. See DSC Community Testing Guidelines.
• [ ] Integration tests updated (where possible). See DSC Community Testing Guidelines.
• [x] Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov[bot]]

Codecov Report

Merging #1823 (cdcdaf0) into main (92612af) will decrease coverage by 0%. The diff coverage is n/a.

@@         Coverage Diff          @@
##           main   #1823   +/-   ##
====================================
- Coverage    91%     91%   -1%     
====================================
  Files        82      81    -1     
  Lines      7433    7429    -4     
====================================
- Hits       6781    6777    -4     
  Misses      652     652           

Flag	Coverage Δ
unit	91% <ø> (-1%)	:arrow_down:

[hollanjs]

@johlju - I think the checks are only failing because Test-IsNumericType has not been merged into DscResource.Common:main yet. That merge is queued up and ready for review as well: DscResource.Common PR #88

If it does need any additional updates, please let me know!

[johlju]

I will release DscResource.Common momentarily, then I re-run the pipeline on this PR.

[johlju]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

Good catch removing the private functions from the previous PR's change log entries in the Unreleased section - I would have totally forgot that 🙂

[johlju]

There seems to be a bug in other parts of the module that fails the tests, that should be unrelated to this change. I can dig into it tomorrow.

[hollanjs]

@johlju let me know if there's anything else I can do on my end.

[johlju]

I don't know how the test passed before. But good thing this bug was caught now. 🙂

The problem was on this line:

https://github.com/dsccommunity/SqlServerDsc/blob/92612af8de4fedca3cb1438e8456428e21a44375/source/Private/Invoke-SetupAction.ps1#L1289

This line calls Test-IsNumericType to determine if the value is numeric. If the value is an array then Test-IsNumericType would wrongly return $false for each value, so intead of returning a single $false for arrays it would return an array of $false or $true (one for each item), making the above line always evaluate to $true for arrays.

I proposed a fix in https://github.com/dsccommunity/DscResource.Common/pull/90.

[johlju]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

@hollanjs thank you for this! 🙇