Closed hollanjs closed 1 year ago
Merging #1840 (d59a357) into main (979800d) will increase coverage by
0%
. The diff coverage is100%
.
@@ Coverage Diff @@
## main #1840 +/- ##
====================================
Coverage 91% 91%
====================================
Files 71 71
Lines 7310 7313 +3
====================================
+ Hits 6661 6664 +3
Misses 649 649
Flag | Coverage Δ | |
---|---|---|
unit | 91% <100%> (+<1%) |
:arrow_up: |
Impacted Files | Coverage Δ | |
---|---|---|
...SCResources/DSC_SqlAGReplica/DSC_SqlAGReplica.psm1 | 100% <100%> (ø) |
@hollanjs awesome work! Looks great at initial glance. Will review later today.
Pull Request (PR) description
This PR alters how the
SqlAGReplica
changes properties of the AvailabilityReplica. Rather than triggering an update for each individual property that is out of state,Update-AvailabilityGroupReplica
now triggers only once at the end, applying all property updates at once.To specifically resolve issues with
FailoverMode
andAvailabilityMode
updates:FailoverMode
checks were moved up beforeAvailabilityMode
checksFailoverMode
andAvailabilityMode
are always updated at the same time. This should hopefully ensure future changes do not cause this issue to come back.This Pull Request (PR) fixes the following issues
Task list
This change is