dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 225 forks source link

SqlServerDsc: Remove `Invoke-SqlScript` #1903

Closed johlju closed 1 year ago

johlju commented 1 year ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #1903 (2d63579) into main (ac13d70) will decrease coverage by 1%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1903   +/-   ##
====================================
- Coverage    92%     92%   -1%     
====================================
  Files        86      86           
  Lines      7661    7631   -30     
====================================
- Hits       7059    7029   -30     
  Misses      602     602           
Flag Coverage Δ
unit 92% <100%> (-1%) :arrow_down:
Impacted Files Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 98% <ø> (-1%) :arrow_down:
...urce/DSCResources/DSC_SqlScript/DSC_SqlScript.psm1 100% <100%> (ø)
...sources/DSC_SqlScriptQuery/DSC_SqlScriptQuery.psm1 100% <100%> (ø)

... and 1 file with indirect coverage changes

johlju commented 1 year ago

When attempting this the verbose functionality of PRINT and RAISEERROR statements are no longer outputted in the verbose output stream. For some reason having the wrapper in a separate module seems to trigger verbose output. Closing this PR as I can't get back that functionality which is important as it is used by Test() to return informational messages.