dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 225 forks source link

SqlLogin: Attempting to disable and already disabled login throws an error #1952 #1953

Closed JoshKingWork closed 1 year ago

JoshKingWork commented 1 year ago

Pull Request (PR) description

Changes from string Exception to just Exception object so InnerException can be searched for error codes

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #1953 (c8bbf70) into main (e52f4a5) will not change coverage. The diff coverage is 50%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1953   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        92      92           
  Lines      7810    7810           
====================================
  Hits       7185    7185           
  Misses      625     625           
Flag Coverage Δ
unit 91% <50%> (ø)
Files Changed Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 96% <50%> (ø)