dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 225 forks source link

SqlServerDsc: Fix handling of `-Force` and `-Confirm $true` in commands #1994

Closed johlju closed 10 months ago

johlju commented 10 months ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

None.

Task list


This change is Reviewable

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a9f8f26) 94% compared to head (eb82951) 94%. Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994/graphs/tree.svg?width=650&height=150&src=pr&token=2L5l2Zcoqd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #1994 +/- ## ==================================== Coverage 94% 94% ==================================== Files 93 93 Lines 7844 7844 ==================================== Hits 7424 7424 Misses 420 420 ``` | [Flag](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | `94% <100%> (ø)` | | | [Files](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [source/Private/Invoke-SetupAction.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1ByaXZhdGUvSW52b2tlLVNldHVwQWN0aW9uLnBzMQ==) | `92% <100%> (ø)` | | | [source/Public/Add-SqlDscTraceFlag.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9BZGQtU3FsRHNjVHJhY2VGbGFnLnBzMQ==) | `95% <100%> (ø)` | | | [source/Public/Disable-SqlDscAudit.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9EaXNhYmxlLVNxbERzY0F1ZGl0LnBzMQ==) | `100% <100%> (ø)` | | | [source/Public/Disconnect-SqlDscDatabaseEngine.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9EaXNjb25uZWN0LVNxbERzY0RhdGFiYXNlRW5naW5lLnBzMQ==) | `100% <100%> (ø)` | | | [source/Public/Enable-SqlDscAudit.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9FbmFibGUtU3FsRHNjQXVkaXQucHMx) | `100% <100%> (ø)` | | | [source/Public/Import-SqlDscPreferredModule.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9JbXBvcnQtU3FsRHNjUHJlZmVycmVkTW9kdWxlLnBzMQ==) | `96% <100%> (ø)` | | | [source/Public/Invoke-SqlDscQuery.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9JbnZva2UtU3FsRHNjUXVlcnkucHMx) | `98% <100%> (ø)` | | | [source/Public/New-SqlDscAudit.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9OZXctU3FsRHNjQXVkaXQucHMx) | `100% <100%> (ø)` | | | [source/Public/Remove-SqlDscAudit.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9SZW1vdmUtU3FsRHNjQXVkaXQucHMx) | `100% <100%> (ø)` | | | [source/Public/Remove-SqlDscTraceFlag.ps1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1B1YmxpYy9SZW1vdmUtU3FsRHNjVHJhY2VGbGFnLnBzMQ==) | `96% <100%> (ø)` | | | ... and [5 more](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/1994?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | |