Closed markaugust closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94%. Comparing base (
a5c29fe
) to head (d926778
).
@johlju I'm not familiar enough with Mocks and Unit test to know exactly what needs to be done here. Looking at the code block, I made some changes to the unit test, but let me know if that's not what you were meaning.
I will review this PR as soon as I have time. Will look over the changes to the test you made. Good work!
Unit tests looks okay, it correctly fails without the proposed change. I push a change to the integration test to try to mimic the scenario in the issue.
@markaugust great work on this!
Thank you @johlju . Out of curiosity, is there a timeline on when those fixes will get moved into a full release branch, rather than just in a preview branch?
Usually when we (community) feel there should be a new full release. I pushed a release tag now, so should release if pipeline don't fail 😊
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Adding a
foreach
loop when checking object permissions to avoid issues with INSERT permissionsTask list
This change is