codykonior
commented
4 months ago It turns out on PowerShell 5.1 it's not possible to look at that AdditionalMetaData property, and none of the other properties on the modules are appropriate to differentiate the two modules, so the major versions need to be hardcoded.
The problematic function is Get-SqlDscPreferredModule, which can be fixed with:
$availableModule = $null
$availableModules = Get-Module -Name $Name -ListAvailable |
Where-Object -FilterScript { $_.Name -ne 'SqlServer' -or $_.Version.Major -le 21 -or $PSVersionTable.PSVersion.Major -ge 7 } |
ForEach-Object -Process {
@{
PSModuleInfo = $_
CalculatedVersion = $_ | Get-SMOModuleCalculatedVersion
}
}
Examples:
PS C:\Windows\system32> $PSVersionTable
Name Value
---- -----
PSVersion 5.1.14393.693
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.14393.693
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
PS C:\Windows\system32> Get-Module SqlServer -ListAvailable
Directory: C:\Program Files\WindowsPowerShell\Modules
ModuleType Version Name ExportedCommands
---------- ------- ---- ----------------
Script 22.3.0 SqlServer {Add-RoleMember, Add-SqlAvailabilityDatabase, Add-SqlAvail...
Script 21.1.18256 SqlServer {Add-RoleMember, Add-SqlAvailabilityDatabase, Add-SqlAvail...
PS C:\Windows\system32> Import-Module SqlServerDsc -Force; Get-SqlDscPreferredModule # Old Code
Directory: C:\Program Files\WindowsPowerShell\Modules
ModuleType Version Name ExportedCommands
---------- ------- ---- ----------------
Script 22.3.0 SqlServer {Add-RoleMember, Add-SqlAvailabilityDatabase, Add-SqlAvail...
PS C:\Windows\system32> Import-Module SqlServerDsc -Force; Get-SqlDscPreferredModule # Fixed Code
Directory: C:\Program Files\WindowsPowerShell\Modules
ModuleType Version Name ExportedCommands
---------- ------- ---- ----------------
Script 21.1.18256 SqlServer {Add-RoleMember, Add-SqlAvailabilityDatabase, Add-SqlAvail...
johlju
Problem description
SqlServerDsc works fine with SqlServer module 21.1.18256 installed. This is the last version (aside from 21.1.18257-preview) which is for PowerShell 5.1.
SqlServer module versions 22 and above (e.g. 22.3.0) require PowerShell 7. This is fine.
However if you have any DSC configurations which use SqlServerDsc, it seems to internally be loading the SqlServer module without validating the version number. This leads it to loading the wrong one (e.g. a PowerShell 7 version under PowerShell 5.1) and this causes all of DSC to fail.
Verbose logs
How to reproduce
Set up DSC resources with SqlServerDsc so that Get-DscConfiguration exits with success. Now copy an SqlServer module 22.3.0 to the system. Then run Get-DscConfiguration again which would go through and re-validate everything.
Expected behavior
Wherever SqlServerDsc does an Import-Module of the SqlServer module it needs to load an appropriate one for the version of PowerShell DSC is running under.
Current behavior
It loads whatever the latest version is instead even though it's for the wrong version of PowerShell.
Suggested solution
It can sort by Version descending, and then select the first one where either AdditionalMetaData.PowerShellVersion does not exist (e.g. on 5.1 version'd modules) or [version] $PSVersionTable.PSVersion -ge AdditionalMetaData.PowerShellVersion.
Operating system the target node is running
PowerShell version and build the target node is running
Module version used