dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 225 forks source link

BREAKING CHANGE: SqlScript, SqlScriptQuery - Add new key 'Id' to allow reuse of a script with different variables #2043

Closed Borgquite closed 3 months ago

Borgquite commented 3 months ago

Pull Request (PR) description

Per discussion in #596 and on #DSC channel, add new key 'Id' to SqlScript, SqlScriptQuery resources, replacing 'InstanceName' and the script variables, allowing reuse of a script with different variables.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94%. Comparing base (c5e7fe7) to head (a4a9faa). Report is 7 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2043/graphs/tree.svg?width=650&height=150&src=pr&token=2L5l2Zcoqd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2043?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #2043 +/- ## ==================================== Coverage 94% 94% ==================================== Files 94 94 Lines 7920 7922 +2 ==================================== + Hits 7490 7492 +2 Misses 430 430 ``` | [Flag](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2043/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2043/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | `94% <100%> (+<1%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2043?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [...urce/DSCResources/DSC\_SqlScript/DSC\_SqlScript.psm1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2043?src=pr&el=tree&filepath=source%2FDSCResources%2FDSC_SqlScript%2FDSC_SqlScript.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9EU0NfU3FsU2NyaXB0L0RTQ19TcWxTY3JpcHQucHNtMQ==) | `100% <100%> (ø)` | | | [...sources/DSC\_SqlScriptQuery/DSC\_SqlScriptQuery.psm1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2043?src=pr&el=tree&filepath=source%2FDSCResources%2FDSC_SqlScriptQuery%2FDSC_SqlScriptQuery.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9EU0NfU3FsU2NyaXB0UXVlcnkvRFNDX1NxbFNjcmlwdFF1ZXJ5LnBzbTE=) | `100% <100%> (ø)` | |
johlju commented 3 months ago

Great work all of you! 🙂