Closed nabrond closed 1 month ago
Attention: Patch coverage is 87.50000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 94%. Comparing base (
3c30929
) to head (c8cbea4
). Report is 3 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 | 87% | 1 Missing :warning: |
Pull Request (PR) description
As documented by Microsoft, the "AddNode" action requires a value for the parameter
FailoverClusterIPAddresses
. The SqlServerDsc module was incorrectly excluding this property from the arguments passed to the setup program. This caused any DSC operations for "AddNode" to fail during theSet-TargetResource
process. This PR makes a minor adjustment to allow the IP property to be emitted when$Action
is set to "AddNode".This Pull Request (PR) fixes the following issues
Task list
This change is