dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 225 forks source link

SqlSetup: Fix AddNode failing due to missing setup parameters #2047

Closed nabrond closed 1 month ago

nabrond commented 1 month ago

Pull Request (PR) description

As documented by Microsoft, the "AddNode" action requires a value for the parameter FailoverClusterIPAddresses. The SqlServerDsc module was incorrectly excluding this property from the arguments passed to the setup program. This caused any DSC operations for "AddNode" to fail during the Set-TargetResource process. This PR makes a minor adjustment to allow the IP property to be emitted when $Action is set to "AddNode".

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94%. Comparing base (3c30929) to head (c8cbea4). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 87% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2047/graphs/tree.svg?width=650&height=150&src=pr&token=2L5l2Zcoqd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2047?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #2047 +/- ## ==================================== Coverage 94% 94% ==================================== Files 94 94 Lines 7922 7930 +8 ==================================== + Hits 7492 7500 +8 Misses 430 430 ``` | [Flag](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2047/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2047/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | `94% <87%> (+<1%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2047?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [source/DSCResources/DSC\_SqlSetup/DSC\_SqlSetup.psm1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2047?src=pr&el=tree&filepath=source%2FDSCResources%2FDSC_SqlSetup%2FDSC_SqlSetup.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9EU0NfU3FsU2V0dXAvRFNDX1NxbFNldHVwLnBzbTE=) | `98% <87%> (+<1%)` | :arrow_up: |