dsccommunity / SqlServerDsc

This module contains DSC resources for deployment and configuration of Microsoft SQL Server.
MIT License
360 stars 225 forks source link

Fix localization hqrm #2050

Closed johlju closed 3 weeks ago

johlju commented 1 month ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94%. Comparing base (5677cd5) to head (b0d72ef). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=2L5l2Zcoqd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #2050 +/- ## ==================================== Coverage 94% 94% ==================================== Files 94 94 Lines 7930 7930 ==================================== Hits 7500 7500 Misses 430 430 ``` | [Flag](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2050/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2050/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | `94% <ø> (ø)` | | | [Files with missing lines](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2050?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1](https://app.codecov.io/gh/dsccommunity/SqlServerDsc/pull/2050?src=pr&el=tree&filepath=source%2FModules%2FSqlServerDsc.Common%2FSqlServerDsc.Common.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL01vZHVsZXMvU3FsU2VydmVyRHNjLkNvbW1vbi9TcWxTZXJ2ZXJEc2MuQ29tbW9uLnBzbTE=) | `96% <ø> (ø)` | |
johlju commented 1 month ago

The issue https://github.com/dsccommunity/DscResource.DocGenerator/issues/160 should be fixed before merging this.