dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.
https://dsccommunity.org
MIT License
70 stars 51 forks source link

Correct BOM on Module Files - Fixes #115 #124

Closed PlagueHO closed 6 years ago

PlagueHO commented 6 years ago

Pull Request (PR) description This PR corrects the BOM on several of the module files and opts into the common module and script validation tests.

This Pull Request (PR) fixes the following issues:

Task list:

@Johlju - this one should be a trivial review. Hope you don't mind - no rush!


This change is Reviewable

codecov-io commented 6 years ago

Codecov Report

Merging #124 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #124   +/-   ##
==================================
  Coverage   94%    94%           
==================================
  Files        5      5           
  Lines      671    671           
==================================
  Hits       636    636           
  Misses      35     35
johlju commented 6 years ago
:lgtm:

Reviewed 6 of 6 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

PlagueHO commented 6 years ago

Thanks @johlju - as always I appreciate this and owe you many, many beers! 🍻