dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.

https://dsccommunity.org

MIT License

71 stars 52 forks source link

Moved entry for new xOpticalDiskDriveLetter resource into Unreleased section - Fixes #135 #136

Closed PlagueHO closed 6 years ago

PlagueHO commented 6 years ago

Pull Request (PR) description This PR is to correct the CHANGELOG.MD entry for a previous PR #133.

The entry got put into the released (3.4.0.0) section instead of the UNRELEASED section.

This Pull Request (PR) fixes the following issues:

Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

@Johlju - would you mind reviewing this? It is just a minor correction to a previous PR I merged (it was looked to be easier to fix in a separate PR).

This change is

codecov-io commented 6 years ago

Codecov Report

Merging #136 into dev will not change coverage. The diff coverage is n/a.

@@        Coverage Diff         @@
##           dev   #136   +/-   ##
==================================
  Coverage   95%    95%           
==================================
  Files        6      6           
  Lines      766    766           
==================================
  Hits       732    732           
  Misses      34     34

johlju commented 6 years ago

Like these tiny PR's :smile:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

johlju commented 6 years ago

@PlagueHO shouldn't xOpticalDiskDriveLetter be a single instance resource? As of now we could move it around thru the entire alphabet in the same configuration since DriveLetter is key? 😉

        xOpticalDiskDriveLetter MapOpticalDiskToZ
        {
             DriveLetter = 'Y'
        }

        xOpticalDiskDriveLetter MapOpticalDiskToZ
        {
             DriveLetter = 'Z'
        }

PlagueHO commented 6 years ago

Doh - you are so correct @johlju - this should be a single instance resource. I've raised a new issue for this (https://github.com/PowerShell/xStorage/issues/138) and I'll get this completed tonight as I want to make sure this is correct when it goes out.

Thank you so much for the review and pointing out this issue!