search

dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.
https://dsccommunity.org
MIT License
70 stars 51 forks source link

Convert xOpticalDiskDriveLetter to SingleInstance pattern resource #138

Closed PlagueHO closed 6 years ago

PlagueHO commented 6 years ago

Because xOpticalDiskDriveLetter can only change the disk letter of a single optical drive in a system then it should use the SingleInstance pattern to ensure only a single resource can be used of this type per config.

johlju commented 6 years ago

I will review this as soon as you send in a PR (or when I wake up) :)

PlagueHO commented 6 years ago

Thanks @johlju - I really appreciate that. I've nearly finished it. I did a bit of a clean up on some of the style issues that I missed in the original PR (actually quite a few). But I knew you'd pick them up so better to fix them :grin:

johlju commented 6 years ago

Sounds great! 😆 It's morning here now, so I will review it as soon as you PR it in.

PlagueHO commented 6 years ago

I'm not sure this resource is correct. I've raised issues in #140

PlagueHO commented 6 years ago

This is no longer required because of PR #141