dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.

https://dsccommunity.org

MIT License

70 stars 51 forks source link

Revert "Disk: correct volume error - drive is read only" #189

Closed PlagueHO closed 5 years ago

PlagueHO commented 5 years ago

I messed up and didn't notice that this PR was made to master branch. So I need to revert it. @johlju - can you review the revert for me?

@JoshuaJSwain - sorry, I didn't notice you'd submitted your PR against master. So I'll need to revert it. Can you please re-raise it against Dev branch for me and I'll get it through.

This change is

codecov-io commented 5 years ago

Codecov Report

Merging #189 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #189   +/-   ##
=====================================
  Coverage      94%    94%           
=====================================
  Files           8      8           
  Lines         873    873           
=====================================
  Hits          821    821           
  Misses         52     52

PlagueHO commented 5 years ago

P.S. We don't want to change anything at all here because this is a pure revert :)

JoshuaJSwain commented 5 years ago

I messed up and didn't notice that this PR was made to master branch. So I need to revert it. @johlju - can you review the revert for me?

@JoshuaJSwain - sorry, I didn't notice you'd submitted your PR against master. So I'll need to revert it. Can you please re-raise it against Dev branch for me and I'll get it through.

This change is

Sorry for my goof, new PR https://github.com/PowerShell/StorageDsc/pull/190

johlju commented 5 years ago

Having an offline discussion about this with @PlagueHO

johlju commented 5 years ago

Looking into if we can just do interactive rebase git rebase -i origin/master and remove the commit, and the force push the master branch.

@PlagueHO What do you think?

PlagueHO commented 5 years ago

Thanks @johlju - I've e-mailed @kwirkykat to see what would be best for her. Mainly just want to make sure the release day all smooth! :grin: So I'll hold this open till I hear from her.

PlagueHO commented 5 years ago

Ps: no worries @JoshuaJSwain - we have all done it :grin: well I know I have.

PlagueHO commented 5 years ago

Woop! No need for this @kwirkykat fixed it for us :grin:

johlju commented 5 years ago

Awesome! Thanks @kwirkykat!