dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.
https://dsccommunity.org
MIT License
71 stars 52 forks source link

Disk: correct volume error - drive is read only #190

Closed JoshuaJSwain closed 5 years ago

JoshuaJSwain commented 5 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

Merging #190 into dev will increase coverage by <1%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           dev   #190    +/-   ##
===================================
+ Coverage   94%    94%   +<1%     
===================================
  Files        8      8            
  Lines      886    889     +3     
===================================
+ Hits       834    837     +3     
  Misses      52     52
PlagueHO commented 5 years ago

Sorry @JoshuaJSwain - I couldn't use reviewable because something is going weird due to the reverted PR. I actually noticed a few things that needed fixing in this PR.

JoshuaJSwain commented 5 years ago

HI @PlagueHO any further fixes I can work on for this one?

JoshuaJSwain commented 5 years ago

thanks @PlagueHO I've pushed the updates

PlagueHO commented 5 years ago

:lgtm:

I'm going to squash merge this.

JoshuaJSwain commented 5 years ago

I see this in dev, curious to see what the release tempo is for 4.6.0.0. I also work on pr 198 when your unit test pr 201 is merged

PlagueHO commented 5 years ago

The DSC Resource kit is released monthly. Usually the week after the community call. So I'd expect the next release date is in the week starting the 1st of April.